Use the details polyfill from frontend toolkit #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-elements-review-pr-562
The details polyfill has been moved to Frontend Toolkit as part of v7.1.0. This is so that users of Elements and Frontend Toolkit can make use of it, as Elements only includes the Sass in its packages. This was raised as part of #400
36degrees
force-pushed
the
use-details-polyfill-from-frontend-toolkit
branch
from
2f8c154 to
1007a56
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-elements-review-pr-562
36degrees
force-pushed
the
use-details-polyfill-from-frontend-toolkit
branch
from
1007a56 to
88e0f9f
Compare
36degrees
changed the title
alex-ju
approved these changes
Oct 3, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details polyfill has been copied to the frontend toolkit and released as v7.1.0.
This updates Elements to use the details polyfill from there instead.
What problem does the pull request solve?
Raised in issue #400
How has this been tested?
I ran Elements locally and ensured that the details polyfill was loading correctly from Frontend Toolkit.
I tested that the details/summary elements worked as expected in Firefox 48 using Browserstack.
Screenshots (if appropriate):
What type of change is it?
Has the documentation been updated?