Fix default text for global cookie message #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include this in /layout.html and /layout-example.html as all templates use these files as a base template
Use this to define a variable for the cookieText
|
cc. @joelanman |
|
looks good! |
gemmaleigh
pushed a commit
that referenced
this pull request
Jun 8, 2017
- Increase skiplink colour contrast PR #263 - alphagov/govuk_template#263 - Fix Scala compile issues for Play template PR #261 - alphagov/govuk_template#261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is another step towards getting the GOV.UK elements app to work in the same way as the prototype kit. 🎆
Add a config file, ensure that server.js uses the config file, then define a cookieText variable and pass the cookieText variable to all views.
Also add the missing blocks for the cookie message in both layout files.
Screenshot before (empty blue cookie banner at the top of the screen):
Screenshot after (cookie banner with text at the top of the screen):