This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Specify an explicit $HOME for nagios scripts that use bundler #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bundler 1.14.0 a feature was added to fallback to a /tmp dir if the user's home dir is not writable (see: rubygems/bundler#4951). As part of this feature bundler outputs a warning that it is doing this. When our check_uricorn_workers script is run by the nagios user it runs a ruby script via bundler using an empty environment which means it has no $HOME env var set. This triggers the warning, which unfortunately goes to stdout and interferes with our script which expects the output to be a number and treats anything else as an error state. If we specify a HOME var when running the ruby script we avoid the problem. We follow the example for setting GOVUK_APP_LOGROOT to /tmp and do the same as this will be globally writable, and hopefully we don't actually have to write anything to run the short ruby script.
|
Deployed branch to integration and forced a puppet run on backend-1.backend. The "unknown" alerts for "expected number of unicorn workers" started to come down as the checks were run. Cleared all in 5mins or so. Chalking this up to a win. |
h-lame
deleted the
cope-with-bundler-output-on-stdout-in-check_unicorn_workers
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bundler 1.14.0 a feature was added to fallback to a /tmp dir if the user's
home dir is not writable (see: rubygems/bundler#4951).
As part of this feature bundler outputs a warning that it is doing this. When
our check_uricorn_workers script is run by the nagios user it runs a ruby script
via bundler using an empty environment which means it has no $HOME env var set.
This triggers the warning, which unfortunately goes to stdout and interferes
with our script which expects the output to be a number and treats anything else
as an error state.
If we specify a HOME var when running the ruby script we avoid the problem. We
follow the example for setting GOVUK_APP_LOGROOT to /tmp and do the same as this
will be globally writable, and hopefully we don't actually have to write
anything to run the short ruby script.