Fix sass files being copied to public directory #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the negative glob to exclude the sass directory after the broader ‘non-negative’ glob, as per the gulp documentation:
> Since globs are matched in array order, a negative glob must follow at least one non-negative glob in an array. The first finds a set of matches, then the negative glob removes a portion of those results. When excluding all files within a directory, you must add /** after the directory name, which the globbing library optimizes internally. [1]
The `{,/**/*}` expansion doesn’t seem to do anything versus including `${config.paths.assets}/**`, so simplify it to remove the expansion.
[1]: https://gulpjs.com/docs/en/getting-started/explaining-globs/#special-character--negative
govuk-design-system-ci
temporarily deployed
to
govuk-prototype-kit-pr-948
vanitabarrett
approved these changes
Oct 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the negative glob to exclude the sass directory after the broader ‘non-negative’ glob, as per the gulp documentation:
The
{,/**/*}expansion doesn’t seem to do anything versus including${config.paths.assets}/**, so simplify it to remove the expansion.Fixes #932