Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error message if no auth set up #380

Closed
wants to merge 3 commits into from

Conversation

colmjude
Copy link

This pull request contains an improved error message for users who have not set up basic auth on their prototypes. It was done after some PaaS testing in which the previous version caused participants a few issues.

There were 2 previous PRs opened for this (See #375 and #377) but this is the tidied up version.

@edwardhorsford
Copy link
Contributor

edwardhorsford commented Apr 26, 2017

Thanks for this change @colmjude.

The line of code is getting rather long now - can it be broken up to be more readable?

I feel like the second line could be shortened and front-loaded - something like this:
"You need to set a username and password to make prototypes visible online"

- shorten and improve second sentence
- split string over multiple lines to make more readable
@colmjude colmjude force-pushed the improve-no-auth-page branch from 0983685 to a3183c1 Compare May 2, 2017 14:30
- use single quotes for strings
- change multiline string to preferred style
@colmjude colmjude force-pushed the improve-no-auth-page branch from fe2df5a to a1d1f59 Compare May 5, 2017 05:39
@colmjude
Copy link
Author

colmjude commented May 8, 2017

Hi @edwardhorsford, I made the suggested changes so think this is ready for checking and hopefully merging. Let me know if there is anything else I can do to improve/fix it.

@joelanman
Copy link
Contributor

@colmjude thanks for this, and apologies for the long delay. We now have a team working on the kit.

To aid discussion, the proposed error page looks like this:

image

the current page looks like this:

image

@joelanman
Copy link
Contributor

Sorry for the delay, and thanks for your work! Unfortunately this is out of date with the latest code (our fault) so we're going to close it.

@joelanman joelanman closed this Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants