Skip to content

Commit

Permalink
Avoid double-nested buttons from step-by-step-navigation
Browse files Browse the repository at this point in the history
Instead, these are added by JS automatically
  • Loading branch information
colinrotherham committed Nov 2, 2018
1 parent 4375b46 commit 2374a47
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 42 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# Unreleased

New features:

- [#634 Avoid double-nested buttons in step-by-step navigation](https://github.com/alphagov/govuk-prototype-kit/pull/634)

# 8.3.0

New features:
Expand Down
49 changes: 7 additions & 42 deletions docs/views/templates/step-by-step-navigation.html
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,7 @@ <h2 class="app-step-nav__title">
</span>

<span class="js-step-title">
<button class="app-step-nav__button app-step-nav__button--title js-step-title-button" aria-expanded="false" aria-controls="step-panel-check-youre-allowed-to-drive-1">
<span class="js-step-title-text">
Check you're allowed to drive
</span>
<span class="app-step-nav__toggle-link js-toggle-link" aria-hidden="true">Show</span>
</button>
Check you're allowed to drive
</span>
</h2>
</div>
Expand Down Expand Up @@ -96,12 +91,7 @@ <h2 class="app-step-nav__title">
</span>

<span class="js-step-title">
<button class="app-step-nav__button app-step-nav__button--title js-step-title-button" aria-expanded="false" aria-controls="step-panel-get-a-provisional-licence-2">
<span class="js-step-title-text">
Get a provisional licence
</span>
<span class="app-step-nav__toggle-link js-toggle-link" aria-hidden="true">Show</span>
</button>
Get a provisional licence
</span>
</h2>
</div>
Expand All @@ -128,12 +118,7 @@ <h2 class="app-step-nav__title">
</span>

<span class="js-step-title">
<button class="app-step-nav__button app-step-nav__button--title js-step-title-button" aria-expanded="false" aria-controls="step-panel-driving-lessons-and-practice-3">
<span class="js-step-title-text">
Driving lessons and practice
</span>
<span class="app-step-nav__toggle-link js-toggle-link" aria-hidden="true">Show</span>
</button>
Driving lessons and practice
</span>
</h2>
</div>
Expand Down Expand Up @@ -171,12 +156,7 @@ <h2 class="app-step-nav__title">
</span>

<span class="js-step-title">
<button class="app-step-nav__button app-step-nav__button--title js-step-title-button" aria-expanded="false" aria-controls="step-panel-prepare-for-your-theory-test-4">
<span class="js-step-title-text">
Prepare for your theory test
</span>
<span class="app-step-nav__toggle-link js-toggle-link" aria-hidden="true">Show</span>
</button>
Prepare for your theory test
</span>
</h2>
</div>
Expand Down Expand Up @@ -209,12 +189,7 @@ <h2 class="app-step-nav__title">
</span>

<span class="js-step-title">
<button class="app-step-nav__button app-step-nav__button--title js-step-title-button" aria-expanded="false" aria-controls="step-panel-book-and-manage-your-theory-test-5">
<span class="js-step-title-text">
Book and manage your theory test
</span>
<span class="app-step-nav__toggle-link js-toggle-link" aria-hidden="true">Show</span>
</button>
Book and manage your theory test
</span>
</h2>
</div>
Expand Down Expand Up @@ -256,12 +231,7 @@ <h2 class="app-step-nav__title">
</span>

<span class="js-step-title">
<button class="app-step-nav__button app-step-nav__button--title js-step-title-button" aria-expanded="false" aria-controls="step-panel-book-and-manage-your-driving-test-6">
<span class="js-step-title-text">
Book and manage your driving test
</span>
<span class="app-step-nav__toggle-link js-toggle-link" aria-hidden="true">Show</span>
</button>
Book and manage your driving test
</span>
</h2>
</div>
Expand Down Expand Up @@ -303,12 +273,7 @@ <h2 class="app-step-nav__title">
</span>

<span class="js-step-title">
<button class="app-step-nav__button app-step-nav__button--title js-step-title-button" aria-expanded="false" aria-controls="step-panel-when-you-pass-7">
<span class="js-step-title-text">
When you pass
</span>
<span class="app-step-nav__toggle-link js-toggle-link" aria-hidden="true">Show</span>
</button>
When you pass
</span>
</h2>
</div>
Expand Down

0 comments on commit 2374a47

Please sign in to comment.