Switch search api workers to use new redis instance in production #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
approved these changes
Sep 16, 2024
theseanything
requested changes
Sep 17, 2024
There was a problem hiding this comment.
We need to specify the new requests as per integration - #2570
|
Addressed here: #2571 |
theseanything
approved these changes
Sep 17, 2024
|
Thanks @theseanything! I would have thought one for a separate PR but happy to update |
|
Sorry, should have made that more clear - I've addressed it in #2571 But that PR needs to be merged before this one. |
|
Ah I get you. Luckily I'm working on something else anyway, so I'll hold off on this till that's merged. 👍 |
callumknights
force-pushed
the
search-api-redis-production-3
branch
from
85f147d to
154dcfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/znEDt0yK/1364-create-new-redis-instance-for-search-api-and-move-search-api-to-it-peri-peri-%F0%9F%8C%B6%EF%B8%8F