Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attributes option ignoring values passed from the safe filter #4938

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Fix attributes option ignoring values passed from the safe filter #4938

merged 3 commits into from
Apr 19, 2024

Commits on Apr 18, 2024

  1. Fix govukAttributes macro not outputting values from the safe filter 

    Updates the `govukAttributes` macro to look for an object that matches the shape of those returned by Nunjucks' `safe` filter. If found, the value of that object is mapped to the value that should be used by the macro.
    @querkmachine
    querkmachine committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5547e41 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @querkmachine
    querkmachine committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4e473eb View commit details
    Browse the repository at this point in the history

  3. Add test for values passed via safe filter

    @querkmachine
    querkmachine committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    fe7a019 View commit details
    Browse the repository at this point in the history