Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exact GitHub Actions versions #3954

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Use exact GitHub Actions versions #3954

merged 3 commits into from
Jul 14, 2023

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Jul 13, 2023

This change adds exact version numbers to all GitHub Actions

Dependabot will now raise PRs for minor/patch updates

Node.js setup

I've also bumped GitHub actions/setup-node back to v3.7.0 (see rollback PR for more info)

Version v3.7.0 now runs cache checks earlier, causing issues when ~/.npm (npm cache) didn't exist. The update revealed that we hadn't anticipated null "Boolean values" (booleans as strings) as shown in:

Fixed in 7874ca4

@colinrotherham colinrotherham requested a review from a team as a code owner July 13, 2023 08:44
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3954 July 13, 2023 08:44 Inactive
This change adds exact version numbers to all GitHub Actions

Dependabot will now raise PRs for minor/patch updates
Looks like our `use-cache` input sometimes defaults to null. This hasn’t been an issue before, but it caused problems with `actions/[email protected]`

See GitHub issue: actions/setup-node#797
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3954 July 13, 2023 11:28 Inactive
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Sounds much safer to have a Dependabot PR to test newer action versions for any version bump rather than having them used by Github automatically 🥳

@colinrotherham colinrotherham merged commit a99c0b8 into main Jul 14, 2023
@colinrotherham colinrotherham deleted the github-actions-pin branch July 14, 2023 15:28
@colinrotherham colinrotherham added the github_actions Pull requests that update GitHub Actions code label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
Development

Successfully merging this pull request may close these issues.

3 participants