-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile GOV.UK Prototype Kit config to package top level #3623
Conversation
c37a3bf
to
039d6c9
Compare
039d6c9
to
f7818b7
Compare
04e5168
to
ece24c1
Compare
f7818b7
to
3bb4c8b
Compare
a36c7f5
to
1d590ee
Compare
3bb4c8b
to
23a5a51
Compare
1d590ee
to
35e1a3e
Compare
23a5a51
to
fca5fe8
Compare
35e1a3e
to
7ffa8cf
Compare
fca5fe8
to
e6c114b
Compare
e6c114b
to
8458905
Compare
8458905
to
3fcf7d1
Compare
3fcf7d1
to
ab45c0b
Compare
Things worked fined with |
Sadly we do two things which only #3498 can unblock
if [[ -n $(git status --porcelain) ]]; then
git filter-branch --force --subdirectory-filter packages/govuk-frontend I've rebased #3498 with this branch so let's test there? |
ab45c0b
to
01fb250
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests with #3498 were OK, so let's merge them both one after the other (rather than going through some tedious rebasing).
@@ -6,6 +6,7 @@ | |||
"files": [ | |||
"src", | |||
"dist", | |||
"govuk-prototype-kit.config.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures GOV.UK Prototype Kit can find the config
But paths at their end are still hard coded: alphagov/govuk-prototype-kit@953830a
This PR moves our GOV.UK Frontend Prototype Kit config for backwards compatibility
govuk-frontend/govuk-prototype-kit.config.json
dist/
prefixThis was previously noted under Restructure govuk-frontend repository for v5 Implications