Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sass-embedded from 1.60.0 to 1.62.0 #3514

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 17, 2023

Bumps sass-embedded from 1.60.0 to 1.62.0.

Changelog

Sourced from sass-embedded's changelog.

1.62.0

  • Deprecate the use of multiple !global or !default flags on the same variable. This deprecation is named duplicate-var-flags.

  • Allow special numbers like var() or calc() in the global functions: grayscale(), invert(), saturate(), and opacity(). These are also native CSS filter functions. This is in addition to number values which were already allowed.

  • Fix a cosmetic bug where an outer rule could be duplicated after nesting was resolved, instead of re-using a shared rule.

1.61.0

  • Potentially breaking change: Drop support for End-of-Life Node.js 12.

  • Fix remaining cases for the performance regression introduced in 1.59.0.

Embedded Sass

  • The JS embedded host now loads files from the working directory when using the legacy API.
Commits
  • 60df05b Update compiler version and release
  • d66b12f Update compiler version and release
  • c537b03 Fix resolving against the working directory in legacy API (#212)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Apr 17, 2023
@dependabot dependabot bot requested a review from a team April 17, 2023 09:57
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3514 April 17, 2023 09:57 Inactive
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/sass-embedded-1.62.0 branch from ae6b887 to cee107d Compare April 18, 2023 11:35
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3514 April 18, 2023 11:35 Inactive
@colinrotherham
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/sass-embedded-1.62.0 branch from cee107d to bcc6df9 Compare April 19, 2023 16:11
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3514 April 19, 2023 16:12 Inactive
@colinrotherham
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/sass-embedded-1.62.0 branch from bcc6df9 to 792c4ec Compare April 20, 2023 17:25
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3514 April 20, 2023 17:26 Inactive
@colinrotherham
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/sass-embedded-1.62.0 branch from 792c4ec to 94d233f Compare April 21, 2023 17:23
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3514 April 21, 2023 17:23 Inactive
@colinrotherham
Copy link
Contributor

colinrotherham commented Apr 24, 2023

Approved but needs a 2nd approval

Source map "mappings" in govuk-frontend-4.6.0.min.css.map (line numbers etc) have changed slightly

These are decoded pairings (encoded in the *.map file, see explainer) from the output to original source:

Diff screenshot from Kaleidoscope app for dist CSS source map output

The commit history mentions performance fixes for selectors but also @media query nesting which may have subtly changed the CSS output. That said, our minifier (CSSNANO) likely hides any final differences but they're still mapped

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/sass-embedded-1.62.0 branch from 94d233f to 60ae8e3 Compare April 24, 2023 12:07
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3514 April 24, 2023 12:07 Inactive
Bumps [sass-embedded](https://github.com/sass/embedded-host-node) from 1.60.0 to 1.62.0.
- [Release notes](https://github.com/sass/embedded-host-node/releases)
- [Changelog](https://github.com/sass/embedded-host-node/blob/main/CHANGELOG.md)
- [Commits](sass/embedded-host-node@1.60.0...1.62.0)

---
updated-dependencies:
- dependency-name: sass-embedded
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/sass-embedded-1.62.0 branch from 60ae8e3 to d1e2c0b Compare April 24, 2023 12:29
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3514 April 24, 2023 12:30 Inactive
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcemaps keep pointing to the right place in the dev tools, so all good ⛵️

@romaricpascal romaricpascal merged commit 2bae1a0 into main Apr 24, 2023
@romaricpascal romaricpascal deleted the dependabot/npm_and_yarn/sass-embedded-1.62.0 branch April 24, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript
Projects
Development

Successfully merging this pull request may close these issues.

3 participants