Make the I18n class private #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2941
romaricpascal
force-pushed
the
i18n-private
branch
from
f79d477 to
f85ce0f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2941
2 tasks
romaricpascal
force-pushed
the
i18n-private
branch
from
f85ce0f to
c7e44cc
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2941
colinrotherham
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the class export from the
all.mjsmoduleThis makes the class unavailable when
importing from theall.mjs, and removes theI18nproperty from theGOVUKFrontentobject. Tests have been updated to not check the presence of the property (and tidied up as they were excluding it when bulk testing the components were available on the object).Flags the class with
@privatein its JSDoc and reinforce that its internal in its descriptionIt won't stop anyone from running
import {I18n} from 'govuk-front/govuk-esm/I18n.mjs, but will make it clear that they'd be using a private class that may change in the future. Unfortunately, we do need to have that file in the package as theaccordion.mjsandcharacter-count.mjsfiles willimportit if they're imported individually.Closes #2927.