-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR title to PR number in Changelog #2382
Conversation
I think 'this was added' makes sense when we're talking about new features, but I'm not sure it quite works for breaking changes – we've not really added anything? We're just asking the user to make a change. |
@36degrees Ah gotcha - thanks. That makes sense. Will revert. |
@EoinShaughnessy Should we do something similar for:
It's a bit confusing to say we added a removal of something? |
@vanitabarrett Hmmm yeah, good point. Should we change the title of #1963 to 'Avoid deprecated |
472516a
to
f873e6c
Compare
This PR adds a previously absent PR title ('Avoid invalid nesting of
<span>
within a<dd>
in summary list') to the Frontend Changelog.