Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use h2 for error summary heading #133

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Use h2 for error summary heading #133

merged 1 commit into from
Jul 17, 2017

Conversation

gemmaleigh
Copy link
Contributor

To avoid having multiple h1s per page when an error occurs and the
summary box is shown, use h2 for the error summary heading.

See govuk-elements #510.

@gemmaleigh
Use h2 for error summary heading
ded4a35 
To avoid having multiple h1s per page when an error occurs and the
summary box is shown, use h2 for the error summary heading.
@gemmaleigh gemmaleigh requested a deployment to govuk-frontend-review-pr-133 July 14, 2017 17:37 Pending
@gemmaleigh gemmaleigh requested a deployment to govuk-frontend-review-pr-133 July 14, 2017 17:37 Pending
kr8n3r
kr8n3r approved these changes Jul 17, 2017
View reviewed changes
Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping Nsync 👍

@gemmaleigh gemmaleigh merged commit 6cead8c into master Jul 17, 2017
@gemmaleigh gemmaleigh deleted the error-summary-heading branch July 17, 2017 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kr8n3r kr8n3r kr8n3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gemmaleigh @kr8n3r