Skip to content

Commit

Permalink
Clean up various parts
Browse files Browse the repository at this point in the history
- Update review app example for 2024 MOG change
- Rename organisation colour test to match what is actually being tested
- Move incorrectly located changelog entry
  • Loading branch information
querkmachine committed Aug 6, 2024
1 parent bb62061 commit 1acd94d
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 14 deletions.
22 changes: 12 additions & 10 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,18 @@ Sass users can also use the `govuk-text-break-word` mixin.

This change was introduced in [pull request #5159: Add break-word typography helper](https://github.com/alphagov/govuk-frontend/pull/5159).

### Recommended changes

#### Update the `$websafe` parameter on the `govuk-organisation-colour` function

The `govuk-organisation-colour` Sass function's `$websafe` parameter on has been renamed to `$contrast-safe`.

This is to more accurately describe the functionality of the parameter.

The old parameter name will stop working in the next major version of GOV.UK Frontend.

This change was introduced in [pull request #3407: Update organisation colours](https://github.com/alphagov/govuk-frontend/pull/3407).

### Fixes

We've made fixes to GOV.UK Frontend in the following pull requests:
Expand All @@ -62,16 +74,6 @@ We've changed the wrapping element to use the `nav` tag to expose it as a naviga

This change was introduced in [pull request #4995: Update Breadcrumb component to improve screen reader accessibility](https://github.com/alphagov/govuk-frontend/pull/4995).

### Update the `$websafe` parameter on the `govuk-organisation-colour` function

The `govuk-organisation-colour` Sass function's `$websafe` parameter on has been renamed to `$contrast-safe`.

This is to more accurately describe the functionality of the parameter.

The old parameter name will stop working in the next major version of GOV.UK Frontend.

This change was introduced in [pull request #3407: Update organisation colours](https://github.com/alphagov/govuk-frontend/pull/3407).

### Fixes

We've made fixes to GOV.UK Frontend in the following pull requests:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@
},
"department-for-levelling-up-housing-communities": {
"name": "Department for Levelling Up, Housing and Communities",
"start": 2021
"start": 2021,
"end": 2024
},
"department-for-science-innovation-technology": {
"name": "Department for Science, Innovation and Technology",
Expand Down Expand Up @@ -135,8 +136,7 @@
},
"ministry-of-housing-communities-local-government": {
"name": "Ministry of Housing, Communities and Local Government",
"start": 2018,
"end": 2021
"start": 2018
},
"ministry-of-justice": {
"name": "Ministry of Justice",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const { compileSassString } = require('@govuk-frontend/helpers/tests')

describe('Organisation colours', () => {
it('should define websafe colours that meet contrast requirements', async () => {
it('should define contrast-safe colours that meet contrast requirements', async () => {
const sass = `
$govuk-new-organisation-colours: true;
Expand Down

0 comments on commit 1acd94d

Please sign in to comment.