Skip to content

Commit

Permalink
Fix details expanded state not announced on iOS
Browse files Browse the repository at this point in the history
For some reason, setting `display: inline-block` on the summary means that VoiceOver on iOS no longer announces the expanded state of the `<details>` element [1].

We were using `display: inline-block` so that the interactive area and the focus state (when visible) were constrained to the text within the `<summary>`.

We can achieve the same thing by using `display: block` with `width: fit-content`.

[1]: https://bugs.webkit.org/show_bug.cgi?id=230408
  • Loading branch information
36degrees authored and owenatgov committed Sep 25, 2024
1 parent 2d3fbaa commit 00371fa
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ We've made fixes to GOV.UK Frontend in the following pull requests:
- [#5278: Fix service navigation mobile toggle spacing](https://github.com/alphagov/govuk-frontend/pull/5278)
- [#5331: Fix Warning Text font weight when <strong> styles are reset](https://github.com/alphagov/govuk-frontend/pull/5331)
- [#5352: Only apply margin to details summary when open](https://github.com/alphagov/govuk-frontend/pull/5352)
- [#5089: Fix details expanded state not announced on iOS](https://github.com/alphagov/govuk-frontend/pull/5089)

## v5.6.0 (Feature release)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
}

.govuk-details__summary {
// Make the focus outline shrink-wrap the text content of the summary
display: inline-block;
display: block;
}

.govuk-details[open] .govuk-details__summary {
Expand Down Expand Up @@ -74,6 +73,9 @@
// Absolutely position the marker against this element
position: relative;

// Make the focus outline shrink-wrap the text content of the summary
width: fit-content;

// Allow for absolutely positioned marker and align with disclosed text
padding-left: govuk-spacing(4) + $govuk-border-width;

Expand Down

0 comments on commit 00371fa

Please sign in to comment.