Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postcode guidance #893

Closed
wants to merge 1 commit into from
Closed

Update postcode guidance #893

wants to merge 1 commit into from

Conversation

terrysimpson99
Copy link
Contributor

No description provided.

@govuk-design-system-ci
Copy link
Collaborator

You can preview this change here:

Built with commit 8ff736c

https://deploy-preview-893--govuk-design-system-preview.netlify.com

@aliuk2012
Copy link
Contributor

This PR relates to this discussion

amyhupe pushed a commit that referenced this pull request Jun 10, 2019
@amyhupe
Copy link
Contributor

amyhupe commented Jun 10, 2019

Hi @terrysimpson99 - thanks for your patience on this.

I've reviewed the content and I think it's mostly good but I want to suggest a couple of changes to the placement and structure.

I've done that as a separate PR (#918) as I didn't want to overwrite your version. Could you take a look? If you're happy, we can close this PR and merge the other one?

@terrysimpson99
Copy link
Contributor Author

terrysimpson99 commented Jun 10, 2019

Hi @amyhupe I'm generally happy with the changes you've made. However, I wanted it to be clear that unnecessary characters should be ignored at the beginning, middle, and end. For example Royal Mail (https://www.royalmail.com/find-a-postcode) ignores undesirable characters in the middle and end but not at the beginning. If you understand what I mean and can encapsulate that, I'm fine with closing this PR and merging the other one. Alternatively, if you think there's a low risk of that happening, I'm fine too. I'll leave it to your judgement.

@amyhupe
Copy link
Contributor

amyhupe commented Jun 11, 2019

Hi @terrysimpson99 – I've now added "beginning, middle and end" as you asked. I'm going to close this PR now and get someone to approve the other one.

@amyhupe amyhupe closed this Jun 11, 2019
amyhupe pushed a commit that referenced this pull request Jun 11, 2019
36degrees pushed a commit that referenced this pull request Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants