Loosen ActionView dep for Rails 5 compatibility. #99
Conversation
| @@ -32,7 +32,7 @@ library for use in the UK Government Single Domain project} | |||
| s.add_dependency "sanitize", "~> 2.1.0" | |||
| s.add_dependency 'nokogiri', '~> 1.5' | |||
| s.add_dependency 'addressable', '>= 2.3.8', '< 3' | |||
| s.add_dependency 'actionview', '~> 4.1' | |||
| s.add_dependency 'actionview', RUBY_VERSION >= '2.3' ? '>= 4.1' : '~> 4.1' | |||
There was a problem hiding this comment.
Nice workaround 👍 . It might be prudent to add an upper bound of '< 6'
There was a problem hiding this comment.
Good point, done.
danielroseman
force-pushed
the
rails5-compatibility
branch
from
ab95eb4 to
9a686d9
Compare
|
This will set a dependency on the version of Ruby that is used on rubygems.org to generate the dependencies for Bundler. Also, if the only dependency is Is this change for build and test time, or for production? |
|
@boffbowsh I'm not sure I understand the distinction - that may be because I don't know what rubygems.org is doing. The point is that I want to be able to use this gem in apps that use Rails 4 or 5. Rails 5 won't even install on earlier Ruby versions, but that shouldn't matter; as I understood it, the dependency graph is calculated when you do (And it turns out that we do use more than |
|
In theory, yes, but Bundler precalcs the dependency tree and generates an endpoint like this: https://index.rubygems.org/info/govspeak. Using Ruby to [non-]determine which versions are available means that endpoint will be unreliable. Could we make this something like |
|
That's basically what I had originally, but then Travis failed to build the gem for Ruby 2.1 and 2.2, see https://travis-ci.org/alphagov/govspeak/builds/164866565. I think there are still apps on those versions that use this, so we probably do want to test against them. |
|
I think we get around this in other gems by using different Gemfiles for testing: https://github.com/alphagov/slimmer/tree/master/gemfiles |
danielroseman
force-pushed
the
rails5-compatibility
branch
from
4ab60cf to
fb57419
Compare
|
@boffbowsh does this look right now? |
|
You'll still need a dependency in the gemspec so that apps know to install actionview. |
This allows the gem to be included in apps that use Rails 5. We test against different versions of Ruby, but ActionView 5 does not build in versions before 2.3. Because the `>=` gem specifier always finds the latest version, we need to use a different specifier for earlier Ruby versions, so this configures Travis to use a different Gemfile for each one.
danielroseman
force-pushed
the
rails5-compatibility
branch
from
fb57419 to
23c3e79
Compare
|
Done. |
Since Travis builds this gem on different Ruby versions, and ActionView 5 won't install on versions before 2.3, we use a conditional expression in the gemspec to ensure it installs the right one.