Render bad usage of markdown as empty strings #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change `[embed:attachments:filename.jpg]` would be rendered on the frontend amongst the content. This change means that it would be rendered as an empty string. Although it is debatable which route is better, having this render empty strings does allow us to resolve some issues with missing attachments on Specialist Publisher.
kevindew
force-pushed
the
gracefully-failing-elements
branch
from
7daaffe to
1edcb6b
Compare
danielroseman
approved these changes
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change
[embed:attachments:filename.jpg]would berendered on the frontend amongst the content. This change means that it
would be rendered as an empty string.
Although it is debatable which route is better, having this render empty
strings does allow us to resolve some issues with missing attachments on
Specialist Publisher.