Restore behaviour of headings being able to be rendered inside example boxes #374
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumknights
force-pushed
the
restore-example-headings
branch
2 times, most recently
from
3c8032d to
fa35a4a
Compare
callumknights
force-pushed
the
restore-example-headings
branch
5 times, most recently
from
38c5866 to
dbe164d
Compare
Headings used to work inside example boxes, that behaviour recently broke and caused issues for publishers, this reinstates that behaviour.
callumknights
force-pushed
the
restore-example-headings
branch
from
dbe164d to
3509809
Compare
brucebolt
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically against govspeak usage guidance, but was behaviour that worked before, and the changing of implementation for example blocks in #350 broke it.
Changing back to previous behaviour for now until more work is done on govspeak components and their interactions.
The strange behaviour with spacing appears to be related to this issue, credit to @brucebolt gettalong/kramdown#213
Trello: https://trello.com/c/UVePLiKZ/1481-re-enable-headings-inside-example-boxes-in-govspeak