Allow inline attachments in numbered lists #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
fix-link-in-ordered-list
branch
2 times, most recently
from
66cf680 to
1e59860
Compare
This test currently fails as links are not supported in numbered lists.
We currently process numbered lists in a two step process: 1. create the list itself 2. parse each line within the list through govspeak again In the second step, govspeak has no knowledge of the attachments as we weren't including this information. Therefore adding in the attachment data, so govspeak can include these inline.
brucebolt
force-pushed
the
fix-link-in-ordered-list
branch
from
1e59860 to
068b2bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, inline attachments do not work if included in a numbered list.
Adding a fix to allow this, as expected by publishers.
See commit messages for implementation details.
After merging and updating the gem in Whitehall, the affected document will need to be republished.
Trello card