Remove PriorityList from Govspeak
#249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
force-pushed
the
remove-priority-list
branch
from
42fee75 to
ce4e080
Compare
BeckaL
reviewed
Jul 26, 2022
There was a problem hiding this comment.
Looks good, and always nice to remove code! Small nitpick, could you squash the last two commits that bump the version into one? Would be nice if the bump to 6.9 doesn't appear in the git history since we decided to go with a major bump in the following commit (which absolutely seems the correct call to me 😄 )
MartinJJones
force-pushed
the
remove-priority-list
branch
from
ce4e080 to
8daca08
Compare
|
Thanks @BeckaL, good point!, I've squashed the last 2 commits as recommended 👍 |
BeckaL
approved these changes
Jul 26, 2022
|
I'm a bit worried that prior to merging this we'll need to adapt content of anything that uses this and update guidance. I wrote more on the components issue |
MartinJJones
changed the title
PriorityList from Govspeak
Priority List is no longer required as the Primary Links JS module used to render the list on the frontend it to be removed from govuk-publishing-components.
Updated the change log to make it clear that the removal of `PriorityList` is a breaking change and set the version number to be the next major version.
MartinJJones
force-pushed
the
remove-priority-list
branch
from
8daca08 to
ef1d4e7
Compare
|
Latest update rebased main to resolve merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove
PriorityList, including related tests and documentation.Why
Priority List is no longer required as the Primary Links JS module used to render the list on the frontend it to be removed from govuk-publishing-components.
Visual Changes
Trello: https://trello.com/c/nezjGrzF/1388-investigate-and-potentially-fix-primary-links-module