Change data source for organisations_for_world_location method
#1204
Conversation
brucebolt
force-pushed
the
update-world-organisation-method
branch
5 times, most recently
from
b2608f2 to
3116981
Compare
brucebolt
force-pushed
the
update-world-organisation-method
branch
3 times, most recently
from
cefe38e to
982b370
Compare
There was a problem hiding this comment.
This looks good to me.
Out of curiosity, did you test to see how much longer the request takes now that we need to fetch multiple content items.
I'm also wondering if it's worth highlighting in the commit messages that we had to make multiple requests because thats the only sensible option at this time?
It takes around 3-4 times longer to make these requests. However I noticed the only application to use this method (Smart Answers) caches the response anyway, so the number of requests should be very minimal.
Nice idea. I'll add that in. |
This ends reliance on the Whitehall API by changing the data source to use Search API and Content Store. The output is in an identical format, but is no longer paginated. Also increasing the test coverage by ensuring we are correctly transforming the data. Previously we only checked that the title was correct. We are having to make multiple requests to Content Store (one per organisation found in Search API) as there is no current way of retreiving this data in bulk. We believe very few organisations have more than a handful of organisations, so the number of requests will be limited.
We are no longer using the Whitehall API, so can remove the pact tests. The equivalent change has been made in Whitehall: alphagov/whitehall#8029
brucebolt
force-pushed
the
update-world-organisation-method
branch
from
982b370 to
2ccad30
Compare
This ends reliance on the Whitehall API by changing the data source to use Search API and Content Store.
The output is in an identical format, but is no longer paginated.
Trello card