Enforce consistent quote style

[benthorner]

Previously we allowed any style of quotation between files and within
the same file, which only serves to increase the mental load when trying
to write consistent code. It would be quite a large change to reenable
the associated RuboCop across the whole of GOV.UK, but this change will
help reduce the quotation choice overhead for at least this repo.

---

Search page examples to sanity check:

• http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/search/all
• http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/search/research-and-statistics
• http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/search/news-and-communications?parent=%2Feducation&topic=c58fdadd-7743-46d6-9629-90bb3ccc4ef0
• http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/get-ready-brexit-check/questions
• http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/drug-device-alerts
• http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/find-eu-exit-guidance-business
• http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/find-eu-exit-guidance-business?keywords=eori&order=relevance
• http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/find-eu-exit-guidance-business?sector_business_area%5B%5D=aerospace&order=topic
• http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/uk-nationals-living-eu
• http://finder-frontend-pr-[THIS PR NUMBER].herokuapp.com/prepare-business-uk-leaving-eu

Other finders

[theseanything]

Ah could the commit message / PR description have the reason for the change?

[benthorner]

I guess not everyone sees is as 'anarchy'. Updated.

[koetsier]

Double quotes are usually used for strings you can interpolate and single quotes for ones you don't - at least that's what I've always used as a guideline as to when to use double/single quotes. So I'd prefer single quotes where possible. (That's also what my RubyMine linter says)

[benthorner]

@koetsier I think this may have come up before ;-).

rubocop/rubocop#5306

We also have something of a precedent for this...

alphagov/content-publisher#169

[kevindew]

While this may risk all hell breaking loose, how about we make this a change in https://github.com/alphagov/govuk-lint ? Though it should have some time for some conversation.

My personal view is anyone who has a preference on either type are wrong, it doesn't matter. But having no consistency, or changing consistency from file-to-file, is annoying, confusing and adds an extra decision you have to make before writing any code in a project.

[koetsier]

@kevindew I was not aware this was such a contentious issue!

I don't feel very strongly about this - single, double, some weird mixture -for me personally I don't think it adds mental load but if it does for others I'm happy either way.

[kevindew]

@kevindew I was not aware this was such a contentious issue!

I don't feel very strongly about this - single, double, some weird mixture -for me personally I don't think it adds mental load but if it does for others I'm happy either way.

Ha yup. It's just one of those classic long term programmer debates like tabs vs spaces, where the debate rages on eternally, with just enough subtleties for preferences to be based on slightly more than aesthetics.

Sorry if my comment came across as an attack on you personally, it was meant as a general comment on the arguments not your particular point.

[benthorner]

Closing in favour of alphagov/govuk-lint#124