Include sanitised supplier name in agreement document filename #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| ) | ||
|
|
||
|
|
||
| def _sanitise_supplier_name(supplier_name): |
There was a problem hiding this comment.
I feel like this shouldn't be private, it's useful in it's own right at least in scripts.
There was a problem hiding this comment.
Yep, fair point. Sorted.
CCS use supplier name to organise their work, so they need it to be included in the filename for the returned agreement documents.
TheDoubleK
force-pushed
the
sanitise-supplier-names
branch
from
76110e0 to
0cfb83d
Compare
TheDoubleK
force-pushed
the
sanitise-supplier-names
branch
from
7e696f1 to
720b1ab
Compare
|
👍 |
TheDoubleK
added a commit
that referenced
this pull request
Nov 3, 2015
Include sanitised supplier name in agreement document filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCS use supplier name to organise their work, so they need it to be included in the filename for the returned agreement documents.
This is exactly the same method used in the script to generate the framework agreement data.
I have confirmed with Chris at CCS that the filename format generated here is good for them to work with.