Fix lots in export #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaaS and PaaS were the wrong way round
Late-breaking requirement from CCS is to also have a file for failed suppliers for generating letters.
|
Could this make use of the sanitise function introduced in Crown-Commercial-Service/digitalmarketplace-utils#203 ? |
|
It could, and I did think that, but wasn't sure it was worth making the change given that we should never need to run this script ever again. But that might have been me being lazy too, it will be a quick fix. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the version of the script that I used to generate the final files for CCS that they are happy with.
Compared to the previous version it:
This now uses the new sanitise supplier name method and so depends on this being merged first: