Auditing fixes #3421
Merged
Auditing fixes #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the Javascript for the intervention component was not being included in this application
- this line was present to override the appearance of list item elements within govspeak, rendered in the header of the /coronavirus page - there are currently no list item elements in the header of the coronavirus page, and since the page is not now being frequently updated it seems safe to remove this style override - we shouldn't be overriding component styles like this anyway, if there's a problem with the component it should be fixed in the component
patrickpatrickpatrick
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / why
Fixes some issues in this application relating to component use, as raised by our component auditing tools. See individual commits for details.
Visual changes
None.