-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test case inserts failing checks into my production consul #20
Comments
I think if anything, the tests should pull up a throwaway consul and use that. |
nh2
added a commit
to nh2/consul-haskell
that referenced
this issue
Jul 13, 2019
Instead, bring up an own instance of consul, and run against that. Fixes test suite deleting production data when built and tested on a production machine.
I've made a commit that fixes this: nh2@63d9f0a But first: #23 |
nh2
added a commit
to nh2/consul-haskell
that referenced
this issue
Jul 14, 2019
Instead, bring up an own instance of consul, and run against that. Fixes test suite deleting production data when built and tested on a production machine.
Subsumed by #25, where I've cherry-picked the relevant commit and made it compile with other recent PRs. |
nh2
added a commit
that referenced
this issue
Jan 18, 2020
Instead, bring up an own instance of consul, and run against that. Fixes test suite deleting production data when built and tested on a production machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This test code
consul-haskell/tests/Main.hs
Lines 308 to 323 in 85bf68a
connects to consul on port 8500 and inserts a TTL check.
When you build the package with tests enabled (which is what many build tools, in my case nix, do by default), this will mess with the consul on your machine.
It doesn't even delete the TTL check, so after the test executable runs, the TTL check will swiftly fail, possibly even paging you.
The text was updated successfully, but these errors were encountered: