Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str 829 enable eoa flag #666

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Str 829 enable eoa flag #666

wants to merge 2 commits into from

Conversation

bewakes
Copy link
Contributor

@bewakes bewakes commented Feb 12, 2025

Description

This PR does the following in light of enabling/disabling EOA transactions in strata evm execution layer:

  1. Adds two node arguments enable_eoa(with default false) and allowed_eoa_addrs(in case eoa is disabled, this would contain bundler address).
  2. Internally creates an EOAMode enum that is either Enabled or Disabled { allowed_eoa_addrs }.

TODO: fn and unit tests

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.

Project coverage is 54.53%. Comparing base (d23d60a) to head (65ea0cd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/reth/node/src/node.rs 0.00% 13 Missing ⚠️
crates/reth/rpc/src/eth/transaction.rs 0.00% 13 Missing ⚠️
crates/reth/rpc/src/lib.rs 0.00% 13 Missing ⚠️
bin/strata-reth/src/main.rs 0.00% 10 Missing ⚠️
crates/reth/rpc/src/eth/mod.rs 0.00% 8 Missing ⚠️
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   54.60%   54.53%   -0.08%     
==========================================
  Files         318      319       +1     
  Lines       34067    34122      +55     
==========================================
+ Hits        18603    18609       +6     
- Misses      15464    15513      +49     
Files with missing lines Coverage Δ
crates/reth/rpc/src/eth/mod.rs 0.00% <0.00%> (ø)
bin/strata-reth/src/main.rs 0.00% <0.00%> (ø)
crates/reth/node/src/node.rs 0.00% <0.00%> (ø)
crates/reth/rpc/src/eth/transaction.rs 0.00% <0.00%> (ø)
crates/reth/rpc/src/lib.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

Commit: dcba50d

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,370,596
EL_BLOCK 97,975
CL_BLOCK 89,783
L1_BATCH 30,419,814
L2_BATCH 3,566
CHECKPOINT 25,699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant