Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BOOST_CURRENT_FUNCTION with C++11 __func__ #762

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Replace BOOST_CURRENT_FUNCTION with C++11 __func__ #762

merged 1 commit into from
Mar 14, 2019

Conversation

BenjaminW3
Copy link
Member

@BenjaminW3 BenjaminW3 commented Mar 13, 2019 •
edited
Loading

Removes one more dependency to boost.

@BenjaminW3 BenjaminW3 added this to the Version 0.4.0 milestone Mar 13, 2019
@BenjaminW3 BenjaminW3 requested a review from a team March 13, 2019 09:38
@sbastrakov
Copy link
Member

Isn't __func__ C99 and not C++11 ? Not sure if that should be a stopper, as now even MSVS seems to support it, just saying.

@BenjaminW3
Copy link
Member Author

You are right, C99. Should not matter for this PR as long as all compilers implement it.

@BenjaminW3 BenjaminW3 mentioned this pull request Mar 13, 2019
Open
@BenjaminW3
Copy link
Member Author

Please approve!

@BenjaminW3 BenjaminW3 merged commit 06dde73 into alpaka-group:develop Mar 14, 2019
@BenjaminW3 BenjaminW3 deleted the topic-remove_boost_current_function branch March 14, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees
No one assigned
Labels
Type:Refactoring
Projects
None yet
Milestone
Version 0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@BenjaminW3 @sbastrakov @ax3l @benjamin-worpitz-goto