Vendor Catch2: v2.5.0 #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminW3
reviewed
Jan 2, 2019
ax3l
force-pushed
the
topic-vendorCatch2
branch
3 times, most recently
from
6c6d269 to
4ed7d81
Compare
|
The changes hit a known bug in gcc-5.5:
It works with gcc-5.4, gcc-4.9 or gcc-6 and also when building with nvcc 10.0. It previously worked because we had been building debug builds only but not release. Could you please revert the changes in |
BenjaminW3
reviewed
Jan 3, 2019
Use the vendored Catch2 in Alpaka instead of installing an external one.
Add the single-header release of Catch 2.5.0 to a third party library for tests.
ax3l
force-pushed
the
topic-vendorCatch2
branch
from
4ed7d81 to
2efe462
Compare
BenjaminW3
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a third-party header for a vendored catch2 for our tests.
Source: https://github.com/catchorg/Catch2/releases
Version: 0.2.5
New CMake Option
By default, we will build the tests with the internally vendored Catch2 in order to make testing easy. If you want to force using an external Catch2 install (expand your
CMAKE_PREFIX_PATHwith its location), then set:-DALPAKA_USE_INTERNAL_CATCH2=OFF