Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect documentation for get_option_latest_trade #559

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Elijah-AO
Copy link
Contributor

Fixes incorrect docstring in get_option_latest_trade():

  • Changed OptionLatestQuoteRequest to OptionLatestTradeRequest
  • Updated return type from Union[Dict[str, Quote], RawData] to Union[Dict[str, Trade], RawData]

This corrects the documentation to match the actual function behavior.

@Elijah-AO Elijah-AO requested a review from hiohiohio as a code owner February 8, 2025 14:38
Copy link
Contributor

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@hiohiohio hiohiohio merged commit 34a1ea9 into alpacahq:master Feb 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants