Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion & minimal implementation: Vite build #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

qq7
Copy link

@qq7 qq7 commented May 12, 2024

Hi Alon, it seemed a bit strange to me that you've decided to write your own bundling system instead of utilizing npm/yarn/pnpm (I went with pnpm in this pull request) with vite, the bundling tool introduced and maintained by vue team, so I decided to build this minimal example so that it's easier for you to evaluate it makes sense for you to use it in the future.

! I have not tested it with a running backend.

in web/app/:
dev environment with hmr:

pnpm install
pnpm run dev

production build:

pnpm install
pnpm run build

This may also be extended with following improvements:

@alonswartz
Copy link
Owner

Hey @qq7, thanks for that!

My initial rationale was to keep it simple, and not require build dependencies. But, the web/app has grown since its inception so it might be time to reconsider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants