Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace parser combinators by FastParse #22

Merged
merged 16 commits into from
Dec 17, 2016
Merged

Replace parser combinators by FastParse #22

merged 16 commits into from
Dec 17, 2016

Conversation

alonsodomin
Copy link
Owner

This PR rewrites the whole implementation of the parser using FastParse instead of Scala Parser Combinators. The reasons behind this change are:

  • FastParse is faster, specially when parsing a self-recursive AST like the one in cron4s
  • Better error messages when parsing fails. Scala Parser Combinators is able to report on the position in which the parser failed but not which was the depest sub-parser that performed the attempt and failed. This feature in FastParse will enable providing with better and more comprehensive error messages.
  • Slow release cycle in Scala Parser Combinators, specially noticed whilst waiting for a Scala 2.12 ScalaJS compatible artifacts.

@codecov-io
Copy link

codecov-io commented Dec 17, 2016

Current coverage is 95.35% (diff: 91.30%)

Merging #22 into master will decrease coverage by 1.44%

@@             master        #22   diff @@
==========================================
  Files            42         40     -2   
  Lines           499        495     -4   
  Methods         470        470          
  Messages          0          0          
  Branches         29         25     -4   
==========================================
- Hits            483        472    -11   
- Misses           16         23     +7   
  Partials          0          0          

Powered by Codecov. Last update 4fa17de...28ad3c6

@alonsodomin alonsodomin merged commit 7da0f91 into master Dec 17, 2016
@alonsodomin alonsodomin deleted the fastparse branch December 17, 2016 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants