Bumped library versions to compile with Scala 3.1.1 #918
Conversation
|
See also #902... lots of people are hoping for the same :-)! |
project/deps.sc
Outdated
| def scalatags = ivy"com.lihaoyi::scalatags:0.9.4" | ||
| def slf4jNop = ivy"org.slf4j:slf4j-nop:1.8.0-beta4" | ||
| def scalatags = ivy"com.lihaoyi::scalatags:0.11.1" | ||
| def slf4jNop = ivy"org.slf4j:slf4j-nop:2.0.0-alpha6" |
There was a problem hiding this comment.
This is upgrading slf4j to 2.x. Shouldn't we stick to 1.x instead?
There was a problem hiding this comment.
Had issue with messages regarding not finding the slf4jNop. Also note that slf4j had a security vulnerability in 2.x but don't think it is this version. Seems to run ok. Is this whats blocking its merge?
There was a problem hiding this comment.
This seems to be the latest version in the 1.x series
https://search.maven.org/artifact/org.slf4j/slf4j-nop/1.7.36/jar
I'm guessing here, but maybe it would be for the best to use that, to maintain as broad compatibility as possible. Also not using alpha/beta versions of libraries is good too.
There was a problem hiding this comment.
Ok. Will have to update and push again.
|
Apologies for the delay. I have made the slf4j changes and made a new commit (687c73c). I have reviewed the conflicts and changed the |
Conflicts: modules/scala/scala-interpreter/src/main/scala/almond/ReplApiImpl.scala modules/scala/scala-interpreter/src/main/scala/almond/VariableInspectorApiImpl.scala project/deps.sc
|
Merging the remaining change, thanks @hmf! |
I came across the pull request WIP: Support for scala 3.1 #896 and took a stab at it. Apparently the TASTy versions between the
2.13.*and3.*.*branches needs to be paired correctly. Version2.13.6is compatible with3.0.*; we need at least2.13.7for the3.1.*versions. Cannot recall were I read this.I have bumped several libraries and the code compiles for all 2.12, 2.13, 3.0 and 3.1 versions. Note that Ammonite has packages compiled for the 2.13.8 branch, however there do not seem to be any cross compilation libraries for 2.13.8. Tests also seem to run correctly.