Prevent omitting empty matches field from complete_reply during json serialization
#785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiendang
changed the title
matches field from complete_reply during json serialization
There was a problem hiding this comment.
Thanks @kiendang!
Maybe we add a non-regression test for that in ProtocolTests? Converting a Completion.Reply to JSON, and checking that it contains "matches":[], for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue when doing completion and there are no matches, the
matchesfield is omitted from the reply message during json serialization, so for example returns{"cursor_start":7,"cursor_end":7,"metadata":{},"status":"ok"}instead of the correct
{"matches":[],"cursor_start":7,"cursor_end":7,"metadata":{},"status":"ok"}Discovered when I was using jupyter console, might cause problems with other jupyter clients as well.
On an unrelated note, also add the white space I missed in my previous PR. Doesn't affect anything, but kinda trips me a little bit once I've noticed it...