Unbound most queues #1159
Merged
Unbound most queues #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't really make sense for us to bound queues here… they all get filled after actions users manually took (like doing "Run all cells" in a notebook with x hundreds cells…), so we can't really get flooded and crash because of that - we're not a web service treating 1000s of req / s…
|
It should be possible to actually add an integration tests for that… 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't really make sense for us to bound queues here… they all get filled after actions users manually took (like doing "Run all cells" in a notebook with x hundreds cells…), so we can't really get flooded and crash because of that - we're not a web service treating 1000s of req / s…
Doing this to address a possible deadlock I've been seeing with the new launcher, with a "Run all cells" in a large notebook (> 50 cells, former size of most bounded queues in Almond) deadlocking things.