Add New Option '--use-thread-interrupt' #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
piiteraq
commented
Oct 24, 2022
piiteraq
commented
- Added new boolean option '--use-thread-interrupt' for allowing kernel to be interrupted using 'Thread.interrupt' method rather than deprecated 'Thread.stop' method. For backward compatibility, default value of this option is 'false', i.e. 'Thread.stop' is used when option is not specified or set to 'false'
- Added entry in documentation for new option
- Ran test suite to ensure default interrupt behavior of kernel is preserved
- Added new boolean option '--use-thread-interrupt' for allowing kernel
to be interrupted using 'Thread.interrupt' method rather than
deprecated 'Thread.stop' method. For backward compatibility,
default value of this option is 'false', i.e. 'Thread.stop' is
used when option is not specified or set to 'false'
- Added entry in documentation for new option
- Ran test suite to ensure default interrupt behavior of kernel
is preserved
alexarchambault
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Thanks @piiteraq!
Sorry for the late review… I was initially under the impression that I wanted to tweak one thing or another in the changes here, but couldn't find time for it at the time, but looking at it again now, it actually all looks good! 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.