Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: amount in installment plan checkout block + update translation #293

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

Our checkout block doesn't display the right installment plan. We fix it by changing the value in the plan by the total_amount of the installment

How to test

As a reviewer, you are encouraged to test the PR locally.

Install a new version of WooCommerce since 8.3.0
Enable the Block option in our module
Display the checkout page with an Alma plan with PnX installment. Check the amount of the installments

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • You understand the impact of this PR on existing code/features
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • The changes include adequate logging and Datadog traces

Copy link

sonarcloud bot commented Nov 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants