Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golf a few proofs #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pitmonticone
Copy link
Contributor

No description provided.

@alma-n
Copy link
Owner

alma-n commented Aug 6, 2024

Thanks for the changes. We will look at them in more detail at a later date. Could you possibly add some explanations regarding the changes you made? As an example specifically: Why use refine over intro and apply?

@pitmonticone
Copy link
Contributor Author

pitmonticone commented Aug 6, 2024

Hi @alma-n, these changes have been made to:

  • Simplify proofs
  • Reduce the number of lines of code
  • Enhance readability of some proofs by using · to indent multiple cases
  • Replace induction' (which will soon be deprecated) with induction
  • Favour proof terms over tactics for quick one-liners
  • Avoid intermediate simp by using simp only if preceding a rigid-input tactic such as apply, exact, rw, etc.

Why use refine over intro and apply?

I have used refine only once just to reduce lines of code. Not a major improvement in that case.

@YaelDillies
Copy link
Collaborator

Replace induction' (which will soon be deprecated) with induction

Where did you get that from? I think there's enough people liking induction' over induction that it still has a long life ahead.

@pitmonticone
Copy link
Contributor Author

pitmonticone commented Aug 6, 2024

In multiple Mathlib PR reviews, I have been advised to replace induction' with induction due to its "suboptimal" status or impending removal, as noted by maintainers such as @sgouezel (for instance, see this discussion).

I'm sorry if I misinterpreted those review comments. However, given these recommendations in Mathlib PRs, I thought it would have been prudent to also suggest this as a best practice for external projects like this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants