Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameters parsing from "Scenario Outline" for pytest-bdd >= 5.0.0 (fixes #636) #716

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

janxen
Copy link
Contributor

@janxen janxen commented Dec 4, 2022

The changes fix the issue #636.

Checklist

@sqandrew
Copy link

sqandrew commented Jan 4, 2023

@sseliverstov or @skhomuti could you please review it? Thanks!

Copy link
Contributor

@delatrie delatrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, everyone! Sorry for taking so long.

@janxen, thank you for a nice PR and for reanimating the long-time-skipped test of scenario outlines. I've made one suggestion, please review it. Other than that, the PR is good to me.

allure-pytest-bdd/src/utils.py Outdated Show resolved Hide resolved
@delatrie delatrie merged commit c1a4b00 into allure-framework:master Jan 18, 2023
@janxen janxen deleted the fix-pytest-bdd-outline branch January 18, 2023 18:45
@robbrad
Copy link

robbrad commented Feb 26, 2023

Still not fixed for me

pytest-bdd = "^6.1.1"
allure-pytest-bdd = "^2.12.0"
pytest-xdist = {extras = ["psutil"], version = "^3.2.0"}

image

error is :

Could not read test result file .\build\allure-results\d48b4a4f-9c33-4fb7-85cd-9dccd37d03b2-result.json
com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot deserialize value of type `java.lang.String` from Object value (token `JsonToken.START_OBJECT`)

@janxen
Copy link
Contributor Author

janxen commented Feb 27, 2023

Hello @robbra,
the release 2.12.0 don't contain these changes. You have to wait for the next release.

beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants