Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature hide self parameter #235

Merged

Conversation

Sup3rGeo
Copy link
Contributor

//: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)

Context

Omits self from parameter list in method calls. Solves #222.

Checklist

@sseliverstov
Copy link
Contributor

Ok, thx, I got it, but current implementation of func_parameters is bugly and I need to few days to fix it

Copy link
Member

@baev baev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sseliverstov sseliverstov merged commit 82b80db into allure-framework:master May 28, 2018
@sseliverstov
Copy link
Contributor

tnx @Sup3rGeo !

@Sup3rGeo Sup3rGeo deleted the feature-hide-self-parameter branch July 3, 2018 10:15
beckerGil pushed a commit to beckerGil/allure-python that referenced this pull request Apr 10, 2023
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants