Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement rlp Decodable and Encodable traits for Signature #90

Closed
wants to merge 2 commits into from

Conversation

tcoratger
Copy link
Contributor

Motivation

Signature should implement alloy_rlp::Encodable and alloy_rlp::Decodable traits.

Solution

Implementation of alloy_rlp::Encodable and alloy_rlp::Decodable traits for Signature with unit tests.

Should close #82.

PR Checklist

  • Added Tests
  • Added Documentation

@prestwich
Copy link
Member

thank you for the contribution! there is some ongoing refactoring work to put the signature type in alloy-core, so some of this work may become part of that

@tcoratger
Copy link
Contributor Author

thank you for the contribution! there is some ongoing refactoring work to put the signature type in alloy-core, so some of this work may become part of that

@prestwich Yes I saw that the issue was already linked to a big PR but as I saw that the signature aspect was not yet implemented on it, I told myself that I could open the specific PR for that.

Feel free to use this as you prefer.

@prestwich
Copy link
Member

prestwich commented Dec 24, 2023

closing as superseded by alloy-rs/core#459, which now contains the tests

@prestwich prestwich closed this Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] impl RLP traits for Signature
2 participants