Fix Pokemon Pinball #154
Open
Fix Pokemon Pinball #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
alloncm
commented
Jan 15, 2025
•
alloncm
commented
- Pokemon Pinball no longer crash on boot
- Fix the stat register not updating the PPU mode when disabled
- Add support for 0x1E cart mode (MBC5)
- Fix MBC5 to ignore out of bounds cart ram (sram) writes and reads
- Improve the debugger
- Update docs and help command
- Add bank specifier to the watch commands
- Add watch values and r/w modes to the watch command
- Improve some commands text output
- break addresses are now "address:bank" - Better output messages - watch prints the value
- Add comment for the menu mutex - Fix cart memory size
- Add support for 0x1E cart type (MBC5) - Fix MBC5 out of range ram access, now ignore / return 0xFF instead of crashing - Fix PPU mode when the PPU is disabled (was the last mode, now its HBLANK)
Turns out (after long debugging session againts sameboy's debugger) that upon access to the mbc5 ram (maybe all the mbc's?) the address is masked with the max address of the ram chip
alloncm
commented
Feb 5, 2025
| @@ -38,15 +38,16 @@ impl<'a> Mbc for Mbc5<'a> { | |||
| 2=>self.rom_bank_number_register = (self.rom_bank_number_register & 0xFF00) | value as u16, | |||
| // high bit 9 | |||
| 3=>self.rom_bank_number_register = (self.rom_bank_number_register & 0x00FF) | ((value as u16) << 8), | |||
| 4|5=>self.ram_bank_number = value, | |||
| 4|5=>self.ram_bank_number = value & 0xF, | |||
There was a problem hiding this comment.
Make sure the rest of the mbc's are fixed too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.