Skip to content

Commit

Permalink
Revert "build: install wheel from Cockpit git main"
Browse files Browse the repository at this point in the history
This reverts commit 60d5f71.

fsinfo is now available in all of our testing images.
  • Loading branch information
allisonkarlitskaya committed Feb 8, 2024
1 parent dd28701 commit edfe2f3
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 32 deletions.
11 changes: 3 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -168,26 +168,21 @@ rpm: $(TARFILE) $(NODE_CACHE) $(SPEC)
rm -r "`pwd`/rpmbuild"
rm -r "`pwd`/output" "`pwd`/build"

# HACK: we need the 'fsinfo' channel supported only in the Python bridge, and
# only on the `main` branch of Cockpit (and not in any released version yet).
# We can re-engage our 'pybridge' scenario logic, which creates and installs a
# wheel from upstream cockpit git. We should remove this once we get all of our
# images with the updated version of the bridge.
ifeq ("pybridge","pybridge")
ifeq ("$(TEST_SCENARIO)","pybridge")
COCKPIT_PYBRIDGE_REF = main
COCKPIT_WHEEL = cockpit-0-py3-none-any.whl

$(COCKPIT_WHEEL):
pip wheel git+https://github.com/cockpit-project/cockpit.git@${COCKPIT_PYBRIDGE_REF}

VM_DEPENDS = $(COCKPIT_WHEEL)
VM_CUSTOMIZE_FLAGS = --upload $(COCKPIT_WHEEL):/var/tmp --script test/install-wheel
VM_CUSTOMIZE_FLAGS = --install $(COCKPIT_WHEEL)
endif

# build a VM with locally built distro pkgs installed
# disable networking, VM images have mock/pbuilder with the common build dependencies pre-installed
$(VM_IMAGE): $(TARFILE) $(NODE_CACHE) packaging/arch/PKGBUILD bots test/vm.install $(VM_DEPENDS)
bots/image-customize --fresh \
bots/image-customize --no-network --fresh \
$(VM_CUSTOMIZE_FLAGS) \
--upload $(NODE_CACHE):/var/tmp/ --build $(TARFILE) \
--script $(CURDIR)/test/vm.install $(TEST_OS)
Expand Down
3 changes: 0 additions & 3 deletions test/browser/browser.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ if grep -q platform:el8 /etc/os-release; then
dnf module switch-to -y nodejs:16
fi

# Install cockpit from git main (for fsinfo)
TMPDIR=/var/tmp pip install git+https://github.com/cockpit-project/cockpit.git@main

# create user account for logging in
if ! id admin 2>/dev/null; then
useradd -c Administrator -G wheel admin
Expand Down
1 change: 0 additions & 1 deletion test/browser/main.fmf
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ require:
- make
- npm
- python3
- python3-pip
test: ./browser.sh
duration: 60m
20 changes: 0 additions & 20 deletions test/install-wheel

This file was deleted.

0 comments on commit edfe2f3

Please sign in to comment.