[DONT MERGE] initial draft for vote extension for late quorum #202
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@giunatale @albttx Added 2 commits to fix compilation and tests, I haven't finish the review yet but that looks very clean so far! |
| if p.MaxVotingPeriodExtension.Seconds() < 0 { | ||
| return fmt.Errorf("max voting period extension must be 0 or greater: %s", p.MaxVotingPeriodExtension) | ||
| } | ||
| if p.MaxVotingPeriodExtension.Seconds() < p.VotingPeriod.Seconds()-p.QuorumTimeout.Seconds() { |
Check notice
Code scanning / CodeQL
Floating point arithmetic
giunatale
force-pushed
the
giunatale/late-quorum-vote-extension
branch
from
f7a24c6 to
b62b421
Compare
add test for QuorumCheckQueue in EndBlocker
Also add more tests
giunatale
force-pushed
the
giunatale/late-quorum-vote-extension
branch
from
b8941b6 to
3c3d45e
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
PR for internal review