Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign Batch Transactions #2

Merged
merged 13 commits into from
May 25, 2020
Merged

Sign Batch Transactions #2

merged 13 commits into from
May 25, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented May 20, 2020

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@jgimeno jgimeno changed the base branch from master to release/v0.37.12 May 20, 2020 14:24
@jgimeno jgimeno mentioned this pull request May 20, 2020
Closed
8 tasks
@jgimeno jgimeno changed the title Jonathan/batch sign from 037 Sign Batch Transactions May 20, 2020
@jgimeno jgimeno marked this pull request as ready for review May 25, 2020 09:37
@jgimeno jgimeno requested a review from alessio as a code owner May 25, 2020 09:37
@jgimeno jgimeno merged commit d1f00b1 into release/v0.37.12 May 25, 2020
@jgimeno jgimeno deleted the jonathan/batch-sign-from-037 branch May 25, 2020 12:07
@alessio
Copy link
Contributor

alessio commented Jun 8, 2020 •
edited
Loading

This has been merged upstream: cosmos/cosmos-sdk#6350 (cosmos-sdk master). We should consider releasing the same tool for cosmos-sdk 0.37.12 official branch (the branch used by gaia stable, aka Cosmos Hub)

cc @nylira @jaekwon

jgimeno pushed a commit that referenced this pull request Feb 19, 2021
@AdityaSripal @colin-axner
Upgrade-Client Followup #2 (#7460)
c9cb02e 
* enforce client-chosen parameters are persisted across upgrades in tendermint clients

* Update x/ibc/light-clients/07-tendermint/types/upgrade.go

Co-authored-by: colin axnér <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio Awaiting requested review from alessio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgimeno @alessio