Update parallel_for.h #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the new macro for detecting NVHPC CUDA mode.
The CUDA-specific binary search implementation has been `#ifdef 0`d for a long time. It didn't perform as well as the sequential implementation and is dead code that uses old dispatch mechanisms. Also remove a load of headers from `system/cuda/execution_policy.h`. These seem to just be bloating compile time and nothing breaks when I remove them. The comments around it don't make sense and looks like this was being used for test bookkeeping?
This is because of NVBugs 2431416. We'll need a fix in nvcc.
I believe `template` is obligatory to indicate that a dependent name `consume_tile` is a template and not a value.
alliepiper
force-pushed
the
if_target
branch
2 times, most recently
from
9eacb66 to
dd8a0be
Compare
alliepiper
force-pushed
the
if_target
branch
3 times, most recently
from
464d313 to
f6aeee4
Compare
alliepiper
force-pushed
the
if_target
branch
2 times, most recently
from
426c5db to
c0e8000
Compare
alliepiper
force-pushed
the
if_target
branch
4 times, most recently
from
b91d99f to
e1a79cf
Compare
alliepiper
force-pushed
the
if_target
branch
3 times, most recently
from
1cbd716 to
f38f2a8
Compare
|
Hey Allison can we get this merged? |
alliepiper
force-pushed
the
if_target
branch
from
f38f2a8 to
224b9a2
Compare
alliepiper
force-pushed
the
if_target
branch
2 times, most recently
from
5cb359c to
132af13
Compare
alliepiper
force-pushed
the
if_target
branch
8 times, most recently
from
99cdc8e to
25b4b04
Compare
alliepiper
force-pushed
the
if_target
branch
7 times, most recently
from
b869c2c to
5a87579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe
templateis obligatory to indicate that a dependent nameconsume_tileis a template and not a value.