Skip to content

Commit

Permalink
Legacy Makefiles: Don't force C++14 with GCC 4.8: round 2.
Browse files Browse the repository at this point in the history
Bug 3043659
Bug 200618218

Reviewed-by: Allison Vacanti <[email protected]>
  • Loading branch information
brycelelbach committed Jul 14, 2020
1 parent 80c0c37 commit 0c81f42
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 30 deletions.
29 changes: 0 additions & 29 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -111,35 +111,6 @@ else
include ../build/common.mk
endif

# Print host compiler version.

VERSION_FLAG :=
ifeq ($(OS),$(filter $(OS),Linux Darwin))
ifdef USEPGCXX # PGI
VERSION_FLAG := -V
else
ifdef USEXLC # XLC
VERSION_FLAG := -qversion
else # GCC, ICC or Clang AKA the sane ones.
VERSION_FLAG := --version
endif
endif
else ifeq ($(OS),win32) # MSVC
# cl.exe run without any options will print its version info and exit.
VERSION_FLAG :=
endif

CCBIN_ENVIRONMENT :=
ifeq ($(OS), QNX)
# QNX's GCC complains if QNX_HOST and QNX_TARGET aren't defined in the
# environment.
CCBIN_ENVIRONMENT := QNX_HOST=$(QNX_HOST) QNX_TARGET=$(QNX_TARGET)
endif

$(info #### CCBIN : $(CCBIN))
$(info #### CCBIN VERSION : $(shell $(CCBIN_ENVIRONMENT) $(CCBIN) $(VERSION_FLAG)))
$(info #### CXX_STD : $(CXX_STD))

ifeq ($(OS), win32)
CREATE_DVS_PACKAGE = $(ZIP) -r built/CUDA-thrust-package.zip bin thrust/internal/test thrust/internal/scripts thrust/internal/benchmark thrust/*.trs $(DVS_COMMON_TEST_PACKAGE_FILES)
APPEND_H_DVS_PACKAGE = $(ZIP) -rg built/CUDA-thrust-package.zip thrust -9 -i *.h
Expand Down
28 changes: 28 additions & 0 deletions internal/build/common_compiler.mk
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,31 @@ CUDACC_FLAGS += -Werror all-warnings

# Print warning numbers with cudafe diagnostics
CUDACC_FLAGS += -Xcudafe --display_error_number

VERSION_FLAG :=
ifeq ($(OS),$(filter $(OS),Linux Darwin))
ifdef USEPGCXX # PGI
VERSION_FLAG := -V
else
ifdef USEXLC # XLC
VERSION_FLAG := -qversion
else # GCC, ICC or Clang AKA the sane ones.
VERSION_FLAG := --version
endif
endif
else ifeq ($(OS),win32) # MSVC
# cl.exe run without any options will print its version info and exit.
VERSION_FLAG :=
endif

CCBIN_ENVIRONMENT :=
ifeq ($(OS), QNX)
# QNX's GCC complains if QNX_HOST and QNX_TARGET aren't defined in the
# environment.
CCBIN_ENVIRONMENT := QNX_HOST=$(QNX_HOST) QNX_TARGET=$(QNX_TARGET)
endif

$(info #### CCBIN : $(CCBIN))
$(info #### CCBIN VERSION : $(shell $(CCBIN_ENVIRONMENT) $(CCBIN) $(VERSION_FLAG)))
$(info #### CXX_STD : $(CXX_STD))

2 changes: 1 addition & 1 deletion internal/build/common_detect.mk
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CXX_STD = c++14
CXX_STD = c++11

ifeq ($(THRUST_TEST),1)
include $(ROOTDIR)/build/getprofile.mk
Expand Down

0 comments on commit 0c81f42

Please sign in to comment.