fix(dropdown): prevent unnecessary macrotasks (#1384)

allianz · Nov 18, 2024 · 7cec758 · 7cec758
1 parent 614661b
commit 7cec758
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/projects/ng-aquila/src/dropdown/dropdown.spec.ts b/projects/ng-aquila/src/dropdown/dropdown.spec.ts
@@ -739,11 +739,8 @@ describe('NxDropdownComponent', () => {
 
         it('should scroll the selected item in the middle of the panel on dropdown change', fakeAsync(() => {
             createTestComponent(ScrollingTestComponent);
-            trigger.click();
-            tick(500);
-            flush();
-            fixture.detectChanges();
-            tick(1);
+            openDropdownByClick();
+
             // 4 * 44 + 22 (half of item height) + 12 (firstItemPaddingTop) - 100 (middle of panel)
             expect(dropdownInstance.panelBody?.nativeElement.scrollTop).toBe(110);
         }));

diff --git a/projects/ng-aquila/src/dropdown/dropdown.ts b/projects/ng-aquila/src/dropdown/dropdown.ts
@@ -750,7 +750,7 @@ export class NxDropdownComponent
                 // defer it for the next cycle to not run in changed after checked errors
                 // the combination of dropdown-item notifying parent and when the parent
                 // tries to fetch the triggerValue from the child throws these errors
-                setTimeout(() => {
+                Promise.resolve().then(() => {
                     if (this._panelOpen) {
                         this._initActiveItem();
                     }